Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add @compileTimeOnly if it is not already defined #91

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Philippus
Copy link
Contributor

solves #90

@xeno-by
Copy link
Member

xeno-by commented Feb 21, 2017

LGTM. Thank you!

@xeno-by xeno-by merged commit d7b8f72 into scalamacros:2.11.8 Feb 21, 2017
@xeno-by
Copy link
Member

xeno-by commented Feb 21, 2017

@Philippus How would you like to see this published? We could cut a 2.1.1 across supported versions of Scala, or we could silently roll this functionality in the 2.1.0 release starting from Scala 2.12.2.

@Philippus
Copy link
Contributor Author

Philippus commented Feb 21, 2017

To me it doesn't sound like a huge problem that warrants a separate release, so I would say put it in the 2.1.0 release. Or does this mean that it will only be fixed for Scala 2.12.2?

@Philippus
Copy link
Contributor Author

it doesn't look like this was published yet? And we are at the 2.1.0 release.

@xeno-by
Copy link
Member

xeno-by commented Jun 6, 2017

What version of Scala are you using?

@Philippus
Copy link
Contributor Author

Let's add it to 2.12.2 ?

@xeno-by
Copy link
Member

xeno-by commented Jun 12, 2017

Looks like I didn't cherry-pick this commit to the branches supporting recent versions of Scala. Neither 2.11.11, nor 2.12.2 releases of paradise have this logic :(

I suggest we cut a 2.1.1 release. What do you think?

@Philippus
Copy link
Contributor Author

Sounds good to me!

@xeno-by
Copy link
Member

xeno-by commented Jun 18, 2017

Published: https://oss.sonatype.org/content/repositories/releases/org/scalamacros/paradise_2.12.2/2.1.1/.

Sorry for the significant delay in responses!

SethTisue pushed a commit to scalacommunitybuild/paradise that referenced this pull request Nov 21, 2017
philosophical refactorings around LogicalTrees and ToMtree
@Philippus Philippus deleted the issue90 branch May 2, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants