This repository has been archived by the owner on Jan 20, 2019. It is now read-only.
Switch from circe-generic to circe-derivation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Jun 18, 2018
There was a problem hiding this comment.
This is awesome, thanks @andyscott !
We haven't moved the tests from the metals repo so CI only checks for compile. I'll follow up by adding the tests so we can be sure it still works as expected :)
|
Sounds good! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from circe-generic to circe-derivation, which is the recommended module for doing generic derivations for Circe. It has the added (and nice) benefit of not relying of Shapeless, so this helps to address https://github.com/scalameta/lsp4s/issues/8 and https://github.com/ensime/ensime-server/pull/1951.