bugfix: [Scala 3] Reset context before each fail section #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were using the same reporter for each fail section, which was causing no more errors to be reported on the next section. Now, we reset the context before compiling, which is creating a new reporter each time and that was already done for `compile` I also tidied it a bit to only use the currently available context which will be fresh on `reset` always. Fixes scalameta#663
|
@tgodzik thanks! cc @armanbilge |
|
@tgodzik is there an ETA on when this fix will appear in a release? It's not a blocker for me, but I was hoping to eventually use failures in my |
|
@erikerlandson in the meantime you should be able to use the snapshot. I think this is the right config: Inside resolvers ++= Repository.sonatypeOssRepos("snapshots")
addSbtPlugin("org.scalameta" % "sbt-mdoc" % "2.3.2+48-c5215673-SNAPSHOT")In ThisBuild / resolvers ++= Repository.sonatypeOssRepos("snapshots") |
|
@armanbilge thanks, I'll give that a try 👍 |
|
I think this is working 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were using the same reporter for each fail section, which was causing no more errors to be reported on the next section.
Now, we reset the context before compiling, which is creating a new reporter each time and that was already done for
compileI also tidied it a bit to only use the currently available context which will be fresh on
resetalways.Fixes #663