Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change yarn to yarn.cmd on Windows #803

Merged
merged 1 commit into from Oct 9, 2023
Merged

Conversation

JD557
Copy link
Contributor

@JD557 JD557 commented Oct 7, 2023

Fix #792

I also checked the recommended way to install yarn (via corepack) and the situation is the same: a yarn file for Unix and a yarn.cmd file for windows (there's also a yarn.ps1 file, but using the cmd seems safer).

I tested locally on my Windows machine and the problem seems to be fixed. I haven't tested this in any Unix machine, however.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This should be a safe change, thanks for checking it out!

@tgodzik tgodzik merged commit d9ec886 into scalameta:main Oct 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work in Windows with Yarn from chocolatey
2 participants