Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for metals status bar #1

Merged
merged 2 commits into from Sep 16, 2019

Conversation

ayoub-benali
Copy link
Collaborator

@ayoub-benali ayoub-benali commented Sep 14, 2019

Support metals/status but given sublime API limitation unfortunately tooltip and command can't be handled.

Peek 2019-09-14 22-39

Having a dedicated plugin for Metals should allows us to simply the installation.
Manually trigger build import, Tweaking Sublime Text for a better productivity and key mappings should work out of the box.

And we can further handle other custom endpoints

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting! Do you think it would be possible to automatically launch the metals-sublime binary by embedding coursier? It would be nice to bring the installation experience closer to vs code

@ayoub-benali
Copy link
Collaborator Author

Do you think it would be possible to automatically launch the metals-sublime binary by embedding coursier?

You mean the plugin would install/update the server when missing ?
I think we need to tweak the LSP package first.
@tomv564 Do you think we can do this within LanguageHandler ?

@olafurpg
Copy link
Member

I mean it would be nice if users didn't have to manually run the coursier bootstrap ... command themselves and add the metals-sublime binary to the PATH. I'm curious if the Metals Sublime package could automatically handle this step on behalf of users, similarly to the Metals VS Code plugin https://github.com/scalameta/metals-vscode/blob/a4ae172b7e87c22cdfa1d27291f7b3e8c9dde4e1/src/extension.ts#L82

It's a bit tricky to get the Java Home directory, custom JVM flags and system properties right but I believe it contributes to a nice out-of-the-box experience :) Either way, this is definitely not blocking this PR, having metals/status working is already a huge UX improvement!

@ayoub-benali ayoub-benali merged commit 33251be into scalameta:master Sep 16, 2019
@tomv564
Copy link

tomv564 commented Sep 16, 2019

@ayoub-benali: I did some work earlier with a LanguageHandler that bundles coursier to automate the setup steps for dotty: https://github.com/tomv564/LSP-dotty/

Nice work!

@ayoub-benali
Copy link
Collaborator Author

this is great thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants