Revert "Merge pull request #1015 from tanishiking/bump-metals-languag… #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpodsiad
approved these changes
Jun 13, 2022
tanishiking
added a commit
to tanishiking/metals-vscode
that referenced
this pull request
Jul 14, 2022
Previously, we reverted the updates to those libraries in scalameta#1018 because of the [issue](scalameta#1016). Now, the fix for the cause is in vscode-languageclient 8.0.2 and we should be able to safe to update those libraries. PR: microsoft/vscode-languageserver-node#972 release note: https://github.com/microsoft/vscode-languageserver-node#3172-protocol-802-json-rpc-802-client-and-802-server
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e-client"
This reverts commit a9dd72c, reversing
changes made to c7bec8d.
There is an issue in the language client discussed here #1016