chore: show release notes on user demand on remote env #1039
Conversation
| const remote = isRemote(); | ||
| if (calledOn === "onExtensionStart" && remote.kind === "left") { | ||
| return remote; | ||
| } |
There was a problem hiding this comment.
Makes more sense to check version first, only after remote. It yields better message: Release notes was not shown: do not show release notes for an older version/already seen version
src/releaseNotesProvider.ts
Outdated
| @@ -128,7 +132,9 @@ async function showReleaseNotesImpl( | |||
|
|
|||
| return isNewerVersion | |||
| ? makeRight(cleanVersion) | |||
| : makeLeft("do not show release notes for an older version"); | |||
| : makeLeft( | |||
| "do not show release notes for an older version/already seen version" | |||
There was a problem hiding this comment.
| "do not show release notes for an older version/already seen version" | |
| `do not show release notes for switching to the older or same version, previous version: ${previousVersion}, current version: ${currentVersion}` |
What do you think about this? I personally think "same version" makes more sense than "already seen version" (if I understand correctly). Also, it would be helpful if there's version information in the message.
There was a problem hiding this comment.
hmm, what about do not show release notes for an older or same version, previous version: ${previousVersion}, current version: ${currentVersion}. switching seems strange to me 🤔
@ckipp01 can you help us here?
There was a problem hiding this comment.
Sorry I'm missing some context, so when would a user see this?
There was a problem hiding this comment.
Release notes should be shown only once for particular version (vs code keeps track of the newest one) and not shown for an older version than was already seen.
This message (it's more a debug one) will be logged to the output tab when any of aforementioned conditions are false:
- release notes were showed for current version
- user is using version older than the last one for which notes were showed
There was a problem hiding this comment.
Ah ok, so something like
not showing release notes since they've already been seen for your current version
???
There was a problem hiding this comment.
👍 to @ckipp01 's comment, my suggestion was too much related to the internal behavior that shouldn't be exposed to end users.
kpodsiad
force-pushed
the
chore/release-notes-remote-env
branch
from
689431f
to
e19c824
Compare
No description provided.