chore: Add various icons for Metals provided extensions and web views #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Aug 22, 2022
src/doctor.ts
Outdated
| @@ -39,6 +48,10 @@ export class DoctorProvider implements Disposable { | |||
| ViewColumn.Active, | |||
| { enableCommandUris: true } | |||
| ); | |||
| if (this.extensionContext) | |||
| this.doctor.iconPath = Uri.file( | |||
| path.join(this.extensionContext.extensionPath, "icons", "doctor.svg") | |||
There was a problem hiding this comment.
I was thinking of having different doctors depending on the theme, but that seemed to be too much on the nose 😅
dos65
approved these changes
Aug 22, 2022
| ] | ||
| ], | ||
| "icon": { | ||
| "dark": "icons/book-dark.svg", |
There was a problem hiding this comment.
Is it a default one for vscode?
I don't see it in pr
There was a problem hiding this comment.
It was actually already added previously, I reused an existing icon.
kpodsiad
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised while investigating how to add extension support for a single file that we can actually provide much better range of icons.
Java/Scala icons are the default vs code ones. The doctor and the stack trace icons are downloaded, but according to the website they are free to use for commercial/personal use.