improvement: Switch to marked to enable links in release notes #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if links were clicked that corresponded to header on the same site `#title-of-h2` it woukld not work due to missing auto generated id. Now, that works correctly with marked and this seems to be used by VS Code also though it appears to be inlined there: https://github.com/microsoft/vscode/blob/4affcdb07c275abdf9944180e7c6e3e82ad3edb2/src/vs/base/common/marked/marked.d.ts
kpodsiad
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if links were clicked that corresponded to header on the same site
#title-of-h2it woukld not work due to missing auto generated id. Now, that works correctly with marked and this seems to be used by VS Code also though it appears to be inlined there:https://github.com/microsoft/vscode/blob/4affcdb07c275abdf9944180e7c6e3e82ad3edb2/src/vs/base/common/marked/marked.d.ts
@kpodsiad was there any reason for using Remarkable?