feature: Run from lenses in local terminal #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgodzik
commented
Oct 24, 2022
•
tgodzik
commented
|
@kpodsiad what do you think? We can also generate lenses with run command and change the data that is being given, but that would not be that much gain and I think having the environment commands in metals server allows us for more flexibility. |
tgodzik
commented
Oct 24, 2022
src/extension.ts
Outdated
| if (args.length == 1) { | ||
| const main = args[0]; | ||
| if (isScalaRunMain(main)) { | ||
| let terminal = window.terminals.find((ter) => ter.name == "Metals"); |
There was a problem hiding this comment.
We could potentially run in any currently open terminal, I think that's what python does.
Or we could try printing to a separate out 🤔 ?
kpodsiad
reviewed
Oct 25, 2022
tgodzik
force-pushed
the
run-locally
branch
4 times, most recently
from
3f8a59f
to
dc7353e
Compare
tgodzik
commented
Oct 27, 2022
src/scalaDebugger.ts
Outdated
| @@ -75,7 +128,7 @@ class ScalaMainConfigProvider implements vscode.DebugConfigurationProvider { | |||
| path: editor.document.uri.toString(true), | |||
| runType: RunType.RunOrTestFile, | |||
| }; | |||
| return start(false, args).then(() => { | |||
| return start(debugConfiguration.noDebug, args).then(() => { | |||
There was a problem hiding this comment.
Turns out that debugConfiguration contains the noDebug flag as a undeclared field. This is useful when running with F5 (Run without debugging)
src/scalaDebugger.ts
Outdated
| @@ -31,10 +36,58 @@ export function initialize(outputChannel: vscode.OutputChannel): Disposable[] { | |||
| ]; | |||
| } | |||
|
|
|||
| function isScalaRunMain(object: any): object is ScalaRunMain { | |||
There was a problem hiding this comment.
I am not super sure about this one, but seems to do the job 😅
This will work in all the cases: - within code lenses - when running with F5 - when running using the discover command I added a command on the server side that will return the main class debug session object to use together with the added shell command. This all uses the same logic, so should work pretty nicely.
kpodsiad
requested changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.