Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change bloop related settings scope to machine #1248

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

kpodsiad
Copy link
Member

@kpodsiad kpodsiad commented Dec 5, 2022

scope - a configuration setting can have one of the following possible scopes:

application - Settings that apply to all instances of VS Code and can only be configured in user settings.

machine - Machine specific settings that can be set only in user settings or only in remote settings. For example, an installation path which shouldn't be shared across machines.

machine-overridable - Machine specific settings that can be overridden by workspace or folder settings.

window - Windows (instance) specific settings which can be configured in user, workspace, or remote settings.

resource - Resource settings, which apply to files and folders, and can be configured in all settings levels, even folder settings.

language-overridable - Resource settings that can be overridable at a language level.

Looking at that machine looks like the best option, doesn't it?

@kpodsiad kpodsiad requested a review from tgodzik December 5, 2022 11:34
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I though machine-overridable was actually the same

@kpodsiad kpodsiad merged commit 955eb44 into scalameta:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants