improvement: Add 'Open issue' to command palette #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Mar 1, 2023
| @@ -490,6 +490,7 @@ function launchMetals( | |||
| ServerCommands.AmmoniteStop, | |||
| ServerCommands.ScalaCliStart, | |||
| ServerCommands.ScalaCliStop, | |||
| "open-new-github-issue", | |||
There was a problem hiding this comment.
languageclient library is not really used anymore by anything aside from the Metals extension, so probably it doesn't make much sense to add it there.
We should instead migrate most of the code here, but I would like to include this command before the release.
There was a problem hiding this comment.
We can embed that library in metals-vscode but in separate dir, so in the future it might be extracted easily, if needed. But having it locally would make things easier 👍
kpodsiad
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.