bugfix: display tests in explorer per workspace folder #1394
Conversation
kasiaMarek
force-pushed
the
multi-root-tests-explorer
branch
2 times, most recently
from
3d2e4e5
to
4d700ee
Compare
|
|
||
| export type MetalsTestItemKind = | ||
| | "workspaceFolder" | ||
| | "project" |
There was a problem hiding this comment.
I wonder if module wouldn't be a better name instead of project
There was a problem hiding this comment.
Agreed, "project" is confusing in this context. If anything a workspace folder should be named "project".
| if ( | ||
| kind === "project" || | ||
| kind === "package" || | ||
| kind === "workspaceFolder" | ||
| ) { |
There was a problem hiding this comment.
I should have write some documentation about this :( Consider adding my loud thoughts as comments/proper doc somewhere.
there is no need to change more bits here because createRunQueue call itself recursively, so almost nothing changed in terms of running - still kind suite is the operating atom here and in result analyzer.
| ): vscode.TestItem { | ||
| const buildTarget = testController.items.get(targetName); | ||
| const buildTarget = workspaceFolderItem.children.get(targetName); | ||
| if (buildTarget) { | ||
| return buildTarget; | ||
| } | ||
|
|
||
| const createdNode = testController.createTestItem(targetName, targetName); |
There was a problem hiding this comment.
Should prefix target's test item id with workspace? Or it isn't necessary because id has to be unique only in a given subtree and if we're child of workspace then we're already guaranteed to be unique?
There was a problem hiding this comment.
@param id Identifier for the TestItem. The test item's ID must be in the {@link TestItemCollection} it's added to
where
TestItemCollection is a collection of test items, found in TestItem.children and TestController.items.
So it only has to be unique among its siblings and we always access it by first accessing the parent (workspace folder).
kasiaMarek
force-pushed
the
multi-root-tests-explorer
branch
from
4d700ee
to
e0cf060
Compare
Previously: test suites were displayed per build target.
Now: we group them also per workspace folder
connected to: scalameta/metals#5212
resolves: scalameta/metals#5189