Add hot code reload #1419
Merged
Add hot code reload #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iusildra
force-pushed
the
add-hot-code-reload
branch
from
ed54f78
to
3e6747c
Compare
iusildra
force-pushed
the
add-hot-code-reload
branch
2 times, most recently
from
63be625
to
595334f
Compare
|
It will need both upcoming versions of the debugger (for the implementation) and metals (for the sync with compilation) to be fully functional Also, before merging I'll need to change the metals server's version before which HCR would not work to give proper information |
tgodzik
requested changes
Aug 25, 2023
iusildra
force-pushed
the
add-hot-code-reload
branch
from
021efd3
to
6168803
Compare
tgodzik
reviewed
Aug 29, 2023
iusildra
force-pushed
the
add-hot-code-reload
branch
from
6168803
to
4a1c36e
Compare
cleaning up allow hcr from specific metals version auto save files before hcr
adpi2
force-pushed
the
add-hot-code-reload
branch
4 times, most recently
from
ae40b85
to
9885716
Compare
adpi2
force-pushed
the
add-hot-code-reload
branch
from
9885716
to
51c854d
Compare
adpi2
force-pushed
the
add-hot-code-reload
branch
from
51c854d
to
2081c31
Compare
|
@tgodzik this PR is ready to be reviewed and merged. It adds the lightning button in the debug tool bar to trigger a hot code reload. |
tgodzik
reviewed
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address this feature request, but for now, it should only works with sbt, I'll look to make it works with bloop too later. I adapted the implementation from vscode-java-debug to work with metals
The implementation on the debugger side is in this pr (not published yet)
There are a few inconsistencies left in my implementation on the VS Code extension:
scalaHotReloadOnis not ticked, the button still appear (we need to tick and untick to make it disappear)