bugfix: Remove locate-java-home #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing we might need want to do is at least try to read java from PATH, not just from env. |
kasiaMarek
reviewed
Apr 18, 2024
| version "1.1.11" | ||
| resolved "https://registry.yarnpkg.com/@viperproject/locate-java-home/-/locate-java-home-1.1.11.tgz#9ae7c281ab005bcbe8b730fee495def0440385f3" | ||
| integrity sha512-cnwxSsB1QB4eeerRd8XsBEDh/BHD1726g/UqA3RAvPBlbZVqzm75jyq+0p9hsVQdtHxUdLRzpjSktck8YEuaAQ== | ||
| "@viperproject/locate-java-home@^1.1.15": |
There was a problem hiding this comment.
do we even need this package anymore?
It seems it uses promises underneath and if anything throws it just hangs, so Metals will never start. I amanged to reproduce it locally, though hopefully doesn't reproduce in a lot of machines
|
I will merge to let people test out since it seems that it fails for more people. I will add code for getting Java from PATH later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems it uses promises underneath and if anything throws it just hangs, so Metals will never start. I manged to reproduce it locally, though hopefully doesn't reproduce in a lot of machines