improvement: Print Java all at once #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
requested changes
May 29, 2024
Comment on lines
41
to
42
| outputChannel.appendLine(`${javaBin} -version:`); | ||
| outputChannel.appendLine(msg); |
There was a problem hiding this comment.
I think the reason we had javaVersionOut.stderr?.on("data", ...) is because, if running java -version fails await javaVersionOut will throw, so (await javaVersionOut).stderr as string won't get printed.
There was a problem hiding this comment.
Ok, good point. I will just remove the initial line with -version there. It's not really adding anything and we already print which java is being looked into before that
kasiaMarek
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that when writing on date we can get one line first and then the other, which would duplicate the
(${javaBin} -version:)message