Add isWholeLine back in case of worksheets
#457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting at an end of an evaluated worksheet
tgodzik
force-pushed
the
fix-worksheet-decorations
branch
from
a09046f
to
d5ef63a
Compare
gabro
approved these changes
Nov 30, 2020
|
I will publish the fix already as the current behaviour can be annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the behaviour when writting at an end of an evaluated worksheet:
and now will move the whole decoration right:
If we ever support implicits inside worksheets we might need auto update the position to the end of line for worksheet decorations.