Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show decorations for visible editors and not just for active one #483

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 8, 2021

Previously, when an editor was visible but not active decorations would not show up, which was a problem especially in case of worksheets, where longer evaluating worksheets would not show if you started doing something for example in the terminal. Now, it should work for all visible editors.

@tgodzik tgodzik requested review from gabro and ckipp01 January 8, 2021 18:18
src/extension.ts Outdated Show resolved Hide resolved
Previously, when an editor was visible but not active decorations would not show up, which was a problem especially in case of worksheets, where longer evaluating worksheets would not show if you started doing something for example in the terminal. Now, it should work for all visible editors.
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit c27c39e into scalameta:master Jan 8, 2021
@tgodzik tgodzik deleted the fix-decorations branch January 8, 2021 19:20
kasiaMarek pushed a commit to kasiaMarek/metals-vscode that referenced this pull request Mar 29, 2023
…rn/types/semver-7.3.12

chore(deps-dev): bump @types/semver from 7.3.11 to 7.3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants