Add commands to run or test the current file or target. #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Mar 12, 2021
src/scalaDebugger.ts
Outdated
| @@ -247,3 +247,14 @@ export interface DebugSession { | |||
| name: string; | |||
| uri: string; | |||
| } | |||
|
|
|||
| export interface DebugDiscoveryParams { | |||
There was a problem hiding this comment.
@ckipp01 should we move these classes to the language client?
There was a problem hiding this comment.
Yea probably. I'll open a pr for that. Also, should we put in the other optional fields?
"args"?: string[],
"jvmOptions"?: string[],
"env"?: {}, // <-- I actually don't know how this is is done in TS to signify it's an object with unknown k v pairs.
"envFile"?: string
There was a problem hiding this comment.
Sure, we can. I haven't added them since they would require using launch.json, which I think might not work when running current file. Also it's kind of weird to set the same options for each file we would run. I think if a user requires arguments etc. then it makes sense to create a dedicated run configuration.
There was a problem hiding this comment.
|
It works pretty cool! 😍 metals-1615550014766.mp4 |
gabro
reviewed
Mar 12, 2021
src/extension.ts
Outdated
| registerTextEditorCommand( | ||
| `metals.test-current-file`, | ||
| (editor, _edit, _args) => { | ||
| let args: DebugDiscoveryParams = { |
There was a problem hiding this comment.
Suggested change
| let args: DebugDiscoveryParams = { | |
| const args: DebugDiscoveryParams = { |
src/extension.ts
Outdated
| registerTextEditorCommand( | ||
| `metals.test-current-target`, | ||
| (editor, _edit, _args) => { | ||
| let args: DebugDiscoveryParams = { |
There was a problem hiding this comment.
Suggested change
| let args: DebugDiscoveryParams = { | |
| const args: DebugDiscoveryParams = { |
tgodzik
force-pushed
the
add-discovery-params
branch
from
a2ccc92
to
43aac4c
Compare
Thanks to @ckipp01 it's now possible to run test or main classes inside the current file. The Metals PR that added this functionality is scalameta/metals#2532
tgodzik
force-pushed
the
add-discovery-params
branch
from
43aac4c
to
c17921f
Compare
kasiaMarek
pushed a commit
to kasiaMarek/metals-vscode
that referenced
this pull request
Mar 29, 2023
…rn/minimatch-3.1.2 chore(deps): bump minimatch from 3.0.4 to 3.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @ckipp01 it's now possible to run test or main classes inside the current file.
The Metals PR that added this functionality is scalameta/metals#2532