-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scala3 increase/decrease indentation and keyword completion #572
Conversation
2664c29
to
2c57df3
Compare
With the latest commits I've implemented the suggested changes, test are implemented, and Tests' CI integration was added. |
73a8695
to
45ff098
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but great work! I would remove some test cases that are not a parseable Scala code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side! @gabro anything typescript wise that we could be doing better here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just a couple of minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, but @Giggiux I think you need to rebase to resolve the conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM, but @Giggiux I think you need to rebase to resolve the conflicts
…est. Fix small regex issue
f1be8f7
to
fde15ef
Compare
This PR merges smarter/vscode-dotty-syntax's changes into metals, allowing for scala3's optional braces syntax support with auto increase and decrease in indentation and new keywords completion.
This is still a WIP, but it's fairly stable.