Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building Node version to v14 #587

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

Giggiux
Copy link
Contributor

@Giggiux Giggiux commented Jun 9, 2021

Node.js v10 Active support ended the 19th of May 2020, the Security Support ended the 30th of April 2021.
the current latest LTS is Node 14 with an end of Security Support in Apr 2023.

The changes in this PR should just update the various Github's Actions to use the latest Node.js 14 version (currently 14.17.0). I tried to build the extension locally with this Node.js version and everything looked ok.

Updating to this version also allows for simpler updates to dependencies, that will slowly losing support for Node.js versions <12.

…upport ended the 30th of April 2021.

the current latest LTS is Node 14 with an end of Security Support in Apr 2023.
These changes should just update the various Github's Actions to use the latest Node.js 14 version (currently 14.17.0).
I tried to build the extension locally with the latest Node.js version and everything looked ok.

Updating to this version also allows for simpler updates to dependencies, that will slowly losing support for Node.js versions <12.
@tgodzik tgodzik requested a review from gabro June 9, 2021 17:37
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I am not sure what that would imply. @gabro could you confirm this is ok 😅 ?

Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabro gabro merged commit 46b6b77 into scalameta:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants