display build target info #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthurm1
force-pushed
the
display_build_target_info
branch
from
42d7047
to
e226987
Compare
tgodzik
reviewed
Jan 31, 2022
src/treeview.ts
Outdated
| @@ -191,6 +191,7 @@ class MetalsTreeDataProvider implements TreeDataProvider<string> { | |||
| ? Uri.parse(item.nodeUri) | |||
| : undefined, | |||
| collapsibleState: toTreeItemCollapsibleState(item.collapseState), | |||
| contextValue: item.contextValue, | |||
There was a problem hiding this comment.
Is this needed in the protocol or can be handle it on the vs code side?
tgodzik
reviewed
Jan 31, 2022
src/treeview.ts
Outdated
| @@ -191,6 +191,7 @@ class MetalsTreeDataProvider implements TreeDataProvider<string> { | |||
| ? Uri.parse(item.nodeUri) | |||
| : undefined, | |||
| collapsibleState: toTreeItemCollapsibleState(item.collapseState), | |||
| contextValue: item.contextValue, | |||
There was a problem hiding this comment.
MAybe:
Suggested change
| contextValue: item.contextValue, | |
| contextValue: if (item.nodeUri.startsWith(projects:) && item.nodeUri.contains("_root_")) "projects" else undefined, |
Something along these lines? (though that is Scala code 😅 )
There was a problem hiding this comment.
You suggestion worked. I've made the change. Adding contextValue to the API is no longer needed.
Arthurm1
force-pushed
the
display_build_target_info
branch
from
e226987
to
c100b43
Compare
|
Languageclient has been released https://github.com/scalameta/metals-languageclient/releases/tag/v0.5.8 🎉 |
kpodsiad
reviewed
Jan 31, 2022
kpodsiad
reviewed
Feb 1, 2022
tgodzik
requested changes
Feb 7, 2022
There was a problem hiding this comment.
Let's bump to newest snapshot once https://github.com/scalameta/metals/actions/runs/1806111245 is released and resolve conflicts.
|
I bumped snapshot version in #836 - there is no need to do this here anymore. |
|
@kpodsiad No problem - thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see scalameta/metals#3380
requires scalameta/metals-languageclient#331