Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FindInJarFiles] Show tree view only after first call #813

Merged
merged 1 commit into from
Jan 7, 2022
Merged

[FindInJarFiles] Show tree view only after first call #813

merged 1 commit into from
Jan 7, 2022

Conversation

dos65
Copy link
Member

@dos65 dos65 commented Jan 6, 2022

Fixes #812

@dos65 dos65 requested a review from tgodzik January 7, 2022 12:56
tgodzik
tgodzik requested changes Jan 7, 2022
View reviewed changes
src/findinfiles.ts Show resolved Hide resolved
tgodzik
tgodzik approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, ignore me, this is exactly how references work.

@tgodzik tgodzik merged commit 16165a2 into scalameta:main Jan 7, 2022
@dos65
Copy link
Member Author

dos65 commented Jan 7, 2022

Actually, ignore me, this is exactly how references work.

Yep, I remember that I had some version of what you proposed but then compared with how default search and references and decided not to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find In files view always shows
2 participants
@dos65 @tgodzik