Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Start Metals button #814

Merged
merged 2 commits into from
Jan 8, 2022
Merged

Add Start Metals button #814

merged 2 commits into from
Jan 8, 2022

Conversation

kpodsiad
Copy link
Member

@kpodsiad kpodsiad commented Jan 7, 2022

No description provided.

tgodzik
tgodzik approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tgodzik
tgodzik requested changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, maybe let's make it simpler?

package.json Outdated Show resolved Hide resolved
@kpodsiad @tgodzik
Update package.json
43b52b3 
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
tgodzik
tgodzik approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Arthurm1
Arthurm1 approved these changes Jan 8, 2022
View reviewed changes
Copy link
Contributor

@Arthurm1 Arthurm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works a treat - thanks @kpodsiad

@tgodzik tgodzik merged commit cd833e7 into scalameta:main Jan 8, 2022
@kpodsiad kpodsiad deleted the start-metals-button branch January 21, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@Arthurm1 Arthurm1 Arthurm1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kpodsiad @tgodzik @Arthurm1