ci: publish pre-release version to VS Code Marketplace #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
Jan 17, 2022
kpodsiad
force-pushed
the
publish-pre-release-versions
branch
from
5cc1d54
to
a15e8fb
Compare
kpodsiad
force-pushed
the
publish-pre-release-versions
branch
from
a15e8fb
to
309a04e
Compare
kpodsiad
commented
Jan 17, 2022
tgodzik
requested changes
Jan 18, 2022
tgodzik
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From docs:
VS Code Marketplace only support major.minor.patch for extension versions and semver pre-release tags are not supported. Support for this will arrive in the future. Because of this we recommend that extensions use major.EVEN_NUMBER.patch for release versions and major.ODD_NUMBER.patch for pre-release versions. For example: 0.2.* for release and 0.3.* for pre-release. VS Code will auto update extensions to the highest version available, so even if a user opted into a pre-release version and there is an extension release with a higher version, that user will be updated to the released version.
Since
semver pre-release tags are not supportedsome workaround has to be created, docs advise usingODD_NUMBERandEVEN_NUMBERfor minors to differentiate between release and pre-release versions. It seems a little bit counterintuitive, hence together with @tgodzik we concluded that this approach will be easier.Release versions will use
major.MINOR.0and pre-release ones will usemajor.minor.PATCH.The
pre-releasejob was added which:needs: [release]because it should run sequentially (in case there is the release, we want to publish pre-release anyway with proper version - bumped both minor and patch)always()-Causes the step to always execute- even when release was skipped