Support synthetic decorations in worksheets #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would have a separate type of decorations for worksheets. Now, we have a separate type for worksheets evaluations and synthetic decorations. Needed for scalameta/metals#3582
tgodzik
commented
Jan 30, 2022
| @@ -1068,9 +1066,6 @@ function launchMetals( | |||
| scalaDebugger.initialize(outputChannel).forEach((disposable) => { | |||
| context.subscriptions.push(disposable); | |||
| }); | |||
| client.onNotification(DecorationTypeDidChange.type, (options) => { | |||
There was a problem hiding this comment.
This is never used and not sure if it actually should.
kpodsiad
approved these changes
Jan 31, 2022
src/extension.ts
Outdated
Comment on lines
1069
to
1071
| client.onNotification(DecorationsRangesDidChange.type, (params) => { | ||
| const editors = window.visibleTextEditors; | ||
| const path = Uri.parse(params.uri).toString(); |
There was a problem hiding this comment.
I've noticed that client.onNotification return Disposable but we're discarding returned value. Maybe it should be added to context.subscriptions (yeah, it's a broader problem)
extension.ts is a very large file, I wonder if we can e.g. create notifications dir and extract all client.onNotification to different files
There was a problem hiding this comment.
I added all the disposables from onNotification to subscriptions. Good idea!
There was a problem hiding this comment.
Thanks, that's a step into good direction ;)
kpodsiad
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would have a separate type of decorations for worksheets. Now, we have a separate type for worksheets evaluations and synthetic decorations.
Needed for scalameta/metals#3582