Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play framework configuration snippet #863

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jan 31, 2022

No description provided.

"mainClass": "play.core.server.ProdServerStart",
"args": [],
"jvmOptions": [],
"buildTarget": "???"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ??? okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the default value that we use in the snippets. It would be better to allow the users choose when creating the snippet, but it's a bit more complicated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only knowledge about build targets wasn't necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it's necessary, since we don't know which target is a play server target :/

We could try to improve it for sure, but we don't keep the main classes from dependencies currently.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace ??? with detailed information on how to fill this field? Like "Type build target name which has a dependency on play.core" or sth like this?

Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question

@@ -726,7 +726,7 @@
},
"buildTarget": {
"type": "string",
"description": "Name of the build target of the class to run"
"description": "Name of the build target of the class to run, can be found in the projects section of the Metals tab"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a bit more info here, which gets displayed when you mouse over the build target. I feel like including the description in the value might be misleading.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@tgodzik tgodzik merged commit 46a22be into scalameta:main Feb 1, 2022
@tgodzik tgodzik deleted the add-play branch February 1, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants