-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add play framework configuration snippet #863
Conversation
"mainClass": "play.core.server.ProdServerStart", | ||
"args": [], | ||
"jvmOptions": [], | ||
"buildTarget": "???" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ???
okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the default value that we use in the snippets. It would be better to allow the users choose when creating the snippet, but it's a bit more complicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If only knowledge about build targets wasn't necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case it's necessary, since we don't know which target is a play server target :/
We could try to improve it for sure, but we don't keep the main classes from dependencies currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we replace ???
with detailed information on how to fill this field? Like "Type build target name which has a dependency on play.core
" or sth like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question
@@ -726,7 +726,7 @@ | |||
}, | |||
"buildTarget": { | |||
"type": "string", | |||
"description": "Name of the build target of the class to run" | |||
"description": "Name of the build target of the class to run, can be found in the projects section of the Metals tab" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a bit more info here, which gets displayed when you mouse over the build target. I feel like including the description in the value might be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
No description provided.