Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use || instead of ?? #892

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix: use || instead of ?? #892

merged 1 commit into from
Feb 17, 2022

Conversation

kpodsiad
Copy link
Member

For some reason an empty string was being taken as a Metals version.

"" || 1 yields 1 where "" ?? 1 yields "" and it's a reason why. ?? was my suggestion at review, guilty as charged.

@kpodsiad kpodsiad requested a review from dos65 February 17, 2022 15:47
dos65
dos65 approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@dos65 dos65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix!

@dos65 dos65 merged commit 6b245dc into scalameta:main Feb 17, 2022
@kpodsiad kpodsiad deleted the fix/get-server-version branch February 17, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dos65 dos65 dos65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpodsiad @dos65