Add mirror setting to help with coursier set up #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Feb 24, 2022
kpodsiad
reviewed
Feb 24, 2022
kpodsiad
requested changes
Feb 24, 2022
Tested it locally and it seems to work correctly replacing the URL used by coursier boostrap
tgodzik
commented
Feb 25, 2022
| export function metalsDir(target: ConfigurationTarget): string { | ||
| if (target == ConfigurationTarget.Workspace && workspace.workspaceFolders) { | ||
| const wsDir = workspace.workspaceFolders[0]?.uri.fsPath; | ||
| return path.join(wsDir, ".metals"); |
There was a problem hiding this comment.
@dos65 I changed the directory for the server version data to .metals since this would be a more consistent naming. We already have things like .bloop etc.
There was a problem hiding this comment.
Hmm. Technically, it isn't it a problem.
I intentionally named is differently for a case when somebody creates a project inside home dir. I understand that it's weird but who knows, maybe that might be a case for a temporal usage(remote/inside container)
kpodsiad
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested it locally and it seems to work correctly replacing the URL used by coursier boostrap