Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show file path for workspace symbols #913

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Mar 11, 2022

Previously, we would not show the path to file containing the symbol, which would be problematic if we had the same name for different symbols. Now, we additionally show the path.

image

@tgodzik tgodzik requested review from dos65 and kpodsiad March 11, 2022 19:27
Previously, we would not show the path to file containing the symbol, which would be problematic if we had the same name for different symbols. Now, we additionally show the path.
Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of pushing suggestions directly.
When you're dealing with possible undefined properties you could use optional chaining syntax ?. - const workspaceUri = workspace.workspaceFolders?.[0]?.uri;

@kpodsiad kpodsiad merged commit f7cdbac into scalameta:main Mar 12, 2022
@tgodzik
Copy link
Contributor Author

tgodzik commented Mar 12, 2022

Perfect! Thanks!

@tgodzik tgodzik deleted the show-location branch March 12, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants