Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create .metals directory if it doesn't exist #973

Merged
merged 1 commit into from
May 6, 2022
Merged

Create .metals directory if it doesn't exist #973

merged 1 commit into from
May 6, 2022

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented May 6, 2022

Fixes #966

@tgodzik tgodzik requested review from dos65 and kpodsiad May 6, 2022 09:23
kpodsiad
kpodsiad approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add braces to the if.
Screenshot 2022-05-06 at 11 24 11

@kpodsiad
Copy link
Member

kpodsiad commented May 6, 2022

It seems like eslint on CI always passes :P I'll take a look at that

@tgodzik
Copy link
Contributor Author

tgodzik commented May 6, 2022

It seems like eslint on CI always passes :P I'll take a look at that

I think works correctly though? It did fail previously, I just fixed it quickly :D

@tgodzik tgodzik merged commit d36216e into scalameta:main May 6, 2022
@tgodzik tgodzik deleted the fix-mirror branch May 6, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodsiad kpodsiad kpodsiad approved these changes

@dos65 dos65 Awaiting requested review from dos65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vs code always Warning "Unable to find a java 11 or java 17 "
2 participants
@tgodzik @kpodsiad