Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send run/test code lenses for clients that don't support debugging #1006

Closed
olafurpg opened this issue Oct 20, 2019 · 0 comments · Fixed by #1012
Closed

Don't send run/test code lenses for clients that don't support debugging #1006

olafurpg opened this issue Oct 20, 2019 · 0 comments · Fixed by #1012
Assignees

Comments

@olafurpg
Copy link
Member

Describe the bug

Using any other editor than VS Code with the latest snapshot shows "run" and "test" code lenses even if the editor is unable to implement the client commands to run and test via Debug Adapter Protocol.

Expected behavior

Metals should not show code lenses for clients that don't include the debuggingProvider = true field in client capabilities, see

https://github.com/scalameta/metals-vscode/blob/09c404b57aff03c56ffecdfb3d5017aa8213790a/src/MetalsFeatures.ts#L19

Installation:

  • Operating system: macOS/Windows/Linux
  • Editor: Atom/Vim/Sublime/Emacs
  • Metals version: v0.7.6 latest SNAPSHOT

Search terms

Warning (lsp-mode): Unknown metals client command: metals-model-refresh 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants