Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update jna, jna-platform to 5.5.0" #1134

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@olafurpg
Copy link
Member

olafurpg commented Dec 3, 2019

This reverts commit a99afaf.

This upgrade caused the same regression on macOS as the directory-watcher upgrade. The PR #1131 was merged this morning before we enabled the macOS CI.

This reverts commit a99afaf.
@olafurpg olafurpg requested a review from tgodzik Dec 3, 2019
@tgodzik
tgodzik approved these changes Dec 3, 2019
Copy link
Collaborator

tgodzik left a comment

Sorry! 😕 Should have waited for the mac tests to work.. The change seemed innocent enough.

@olafurpg

This comment has been minimized.

Copy link
Member Author

olafurpg commented Dec 3, 2019

All these issues makes me want to replace our usage of nuprocess with j.l.ProcessBuilder 😏

@olafurpg olafurpg merged commit caf78af into scalameta:master Dec 3, 2019
10 checks passed
10 checks passed
ubuntu-latest tests
Details
windows-latest tests
Details
macOS-latest tests
Details
Sbt integration
Details
Maven integration
Details
Gradle integration
Details
Mill integration
Details
Slow tests
Details
Scala cross tests
Details
Scalafmt/Scalacheck/Docs
Details
@olafurpg olafurpg deleted the olafurpg:revert-jna-upgrade branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.