Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update jna, jna-platform to 5.5.0" #1134

Merged
merged 1 commit into from Dec 3, 2019

Conversation

olafurpg
Copy link
Member

@olafurpg olafurpg commented Dec 3, 2019

This reverts commit a99afaf.

This upgrade caused the same regression on macOS as the directory-watcher upgrade. The PR #1131 was merged this morning before we enabled the macOS CI.

@olafurpg olafurpg requested a review from tgodzik December 3, 2019 14:01
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! 😕 Should have waited for the mac tests to work.. The change seemed innocent enough.

@olafurpg
Copy link
Member Author

olafurpg commented Dec 3, 2019

All these issues makes me want to replace our usage of nuprocess with j.l.ProcessBuilder 😏

@olafurpg olafurpg merged commit caf78af into scalameta:master Dec 3, 2019
@olafurpg olafurpg deleted the revert-jna-upgrade branch December 3, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants