Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding unmanaged source directories for mtags3 #1842

Merged
merged 2 commits into from
Jun 19, 2020

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 19, 2020

No description provided.

}
if (isScala024(partialVersion)) {
result += base / "scala-0.24"
partialVersion.collect {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should simplify things and make it more future proof.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I like this. Good idea 👍

@@ -338,6 +325,7 @@ val mtagsSettings = List(
lazy val mtags3 = project
.in(file(".mtags"))
.settings(
unmanagedSourceDirectories.in(Compile) := Seq(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order not to add .mtags directories, although it seems that sbt now created the .mtags directory anyway.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this looks good. LGMT!

@tgodzik tgodzik merged commit 966173f into scalameta:master Jun 19, 2020
@tgodzik tgodzik deleted the fix-directories branch June 19, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants