New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing docs and move versions to a more prominent location. #1934
Conversation
|
||
Whenever text is paste into a multiline string with `|` it will be properly | ||
formatted by Metals: | ||
|
||
![format-on-paste](https://i.imgur.com/yJLAIxQ.gif) | ||
![format-on-paste](https://i.imgur.com/fF0XWYC.gif) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added better gifs, because the previous ones were bother me quite a bit 😅
docs/editors/overview.md
Outdated
All editors use a separate Metals server underneath, which version can be | ||
changed idependently. It can be used to checkout newest features from the main | ||
branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory though, this could change moving forward no? Now that everything can be configured via InitializationOptions
, there is no need to have a metals-vscode
and metals-emacs
but a single metals
for each desired version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... right. Maybe then I will just remove the section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved the lower paragraph here.
@@ -323,7 +323,7 @@ Then, when on the line that you'd like to expand the decoration to get the hover | |||
|
|||
coc-metals has a built-in implementation of the [Tree View | |||
Protocol](https://scalameta.org/metals/docs/editors/tree-view-protocol.html). | |||
If you have the [recommended mappings](coc-mappings.vim) copied, you'll notice | |||
If you have the [recommended mappings](vim.md#recommended-cocnvim-mappings) copied, you'll notice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, since it's the same page this doesn't need to be prefaced with vim.md
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ach, right. I will remove it. I never remember the exact syntax needed, so I experiment a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I am getting a warning without it, so I will leave it as is.
docs/editors/vim.md
Outdated
@@ -411,6 +411,14 @@ install [coc-json](https://github.com/neoclide/coc-json). | |||
```scala mdoc:user-config:lsp-config-coc | |||
``` | |||
|
|||
```scala mdoc:parent-lenses:vim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have a whole section on this further down. https://scalameta.org/metals/docs/editors/vim.html#goto-super-method
I'd say remove it and replace it with this, but then my readme and this document becomes quite a bit different. I don't love having them both, but I also don't like not having a detailed readme 🤔 I'm not really sure what would be best for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't noticed it. I can just add it to the VS Code section then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from vim section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you still need a scalafix run, but other than that LGTM!
…t lenses. Also, move versions table to a more prominent location
This PR adds the following: