Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala 3 template was moved from lampepfl org #2295

Merged
merged 1 commit into from Dec 7, 2020
Merged

Scala 3 template was moved from lampepfl org #2295

merged 1 commit into from Dec 7, 2020

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Dec 7, 2020

Follow up from #2294

It changed again and I haven't really noticed 馃槗

@tgodzik tgodzik requested a review from ckipp01 December 7, 2020 18:07
ckipp01
ckipp01 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol teaches us to change things without actually testing that they work 馃槵 LGTM!

@ckipp01
Copy link
Member

ckipp01 commented Dec 7, 2020

Just tested this out, and it works aok. I'm going to go ahead and merge it right away.

@ckipp01 ckipp01 merged commit 018a3e7 into scalameta:main Dec 7, 2020
@kpbochenek
Copy link
Contributor

@ckipp01 even if you tested that it would simply work. When you move project from one workspace to another github actually creates a symlink in previous place to link to a new one.
You can try create new project even now from lampepfl/scala3.g8 and it will still work.

@ckipp01
Copy link
Member

ckipp01 commented Dec 8, 2020

@ckipp01 even if you tested that it would simply work. When you move project from one workspace to another github actually creates a symlink in previous place to link to a new one.
You can try create new project even now from lampepfl/scala3.g8 and it will still work.

ahh true, good point!

@tgodzik tgodzik deleted the update-scala3-template branch October 20, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tgodzik @ckipp01 @kpbochenek