Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Coursier from 2.0.12 to 2.0.13 for bootstrap launcher enhancement to download artifacts using global credentials. #2597

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

greg-a-atkinson
Copy link
Contributor

@greg-a-atkinson greg-a-atkinson commented Mar 11, 2021

An upgrade of Coursier from 2.0.12 to 2.0.13 includes the enhancement:

Launchers created by cs bootstrap and cs install are now able to read and use credentials when fetching artifacts. (coursier/coursier#1991)

This should resolve the 401 Unauthorized errors when Metals downloads artifacts from mirror repositories that require authentication:

Java home: C:\Users\user\working\tools\jdk1.8.0_261-x64
Metals version: 0.9.10
Error while downloading https://private.artifactory.com/artifactory/virtual-java/com/chuusai/shapeless_2.12/2.3.3/shapeless_2.12-2.3.3.jar: Server returned HTTP response code: 401 for URL: https://private.artifactory.com/artifactory/virtual-java/com/chuusai/shapeless_2.12/2.3.3/shapeless_2.12-2.3.3.jar, ignoring it
Error while downloading https://private.artifactory.com/artifactory/virtual-java/com/github/alexarchambault/case-app-annotations_2.12/2.0.0-M9/case-app-annotations_2.12-2.0.0-M9.jar: Server returned HTTP response code: 401 for URL: https://private.artifactory.com/artifactory/virtual-java/com/github/alexarchambault/case-app-annotations_2.12/2.0.0-M9/case-app-annotations_2.12-2.0.0-M9.jar, ignoring it
Error while downloading https://private.artifactory.com/artifactory/virtual-scala/com.lightbend/emoji_2.12/1.2.1/jars/emoji_2.12.jar: Server returned HTTP response code: 401 for URL: https://private.artifactory.com/artifactory/virtual-scala/com.lightbend/emoji_2.12/1.2.1/jars/emoji_2.12.jar, ignoring it
Error while downloading https://private.artifactory.com/artifactory/virtual-java/com/github/alexarchambault/argonaut-shapeless_6.2_2.12/1.2.0-M11/argonaut-shapeless_6.2_2.12-1.2.0-M11.jar: Server returned HTTP response code: 401 for URL: https://private.artifactory.com/artifactory/virtual-java/com/github/alexarchambault/argonaut-shapeless_6.2_2.12/1.2.0-M11/argonaut-shapeless_6.2_2.12-1.2.0-M11.jar, ignoring it

…ment to download artifacts using global credentials.
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the pr @greg-a-atkinson! The linked work looks great. LGTM!

@ckipp01 ckipp01 merged commit dc0da65 into scalameta:main Mar 12, 2021
@greg-a-atkinson
Copy link
Contributor Author

Thanks @ckipp01 for reviewing and merging.

@tgodzik
Copy link
Contributor

tgodzik commented Mar 12, 2021

We also need to upgrade coursier bootstrap inside the extension with is more important:

scalameta/metals-vscode#519

I can release a new version there right away if needed.

@greg-a-atkinson
Copy link
Contributor Author

Fantastic, thank you @tgodzik.

Please feel free to raise a release at your discretion. I'm happy to wait if that will align with whatever the usual release cadence is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants