Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to welcome messages to use '-F' flag #2708

Merged
merged 1 commit into from Apr 14, 2021

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Apr 14, 2021

Connected to scalameta/munit#348

So this is kind of a middle ground until we fix it in munit.

@tgodzik tgodzik requested a review from ckipp01 April 14, 2021 09:23
@tgodzik
Copy link
Contributor Author

tgodzik commented Apr 14, 2021

Fun, so it seems it is all getting worse now :| Every single test DAP that was run on ubuntu failed.

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ckipp01
Copy link
Member

ckipp01 commented Apr 14, 2021

Fun, so it seems it is all getting worse now :| Every single test DAP that was run on ubuntu failed.

Yea that's no bueno :/

@tgodzik tgodzik merged commit 8033d7e into scalameta:main Apr 14, 2021
@tgodzik tgodzik deleted the add-hint branch April 14, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants