Add in the parentUri when offering the newSymbol code action. #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most clients don't have an issue with this, but I just hit on a case where the server providing `null` here is causing issues when the client then tries to encode the value to send back and it chokes on it. In this specific case, we do this step later if it's passed in as null, but since we already have what we need to fill in the parentUri where the new file will be created, we just do that right away instead of passing in `null`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most clients don't have an issue with this, but I just hit on a case
where the server providing
nullhere is causing issues when the clientthen tries to encode the value to send back and it chokes on it. In this
specific case, we do this step later if it's passed in as null, but
since we already have what we need to fill in the parentUri where the
new file will be created, we just do that right away instead of passing
in
null.