Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for v0.10.3 release #2781

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented May 14, 2021

No description provided.

Copy link
Collaborator

@Giggiux Giggiux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Two small nits. Take them or leave them. LGTM!

Comment on lines 60 to 61
and objects. The code action will not show if the definition we are extracting
is or extends a `sealed` definition.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and objects. The code action will not show if the definition we are extracting
is or extends a `sealed` definition.
and objects. The code action will not show if the definition we are trying to extract
is or extends a `sealed` definition.

Comment on lines 65 to 67
The extraction happens via a code action on the definition's name, it will also
extract any relevant package definition, imports, and, if available, the
companion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd maybe recommend just bumping this sentence up to the above one before the gif. It seems like it's just floating alone here.

@tgodzik
Copy link
Contributor Author

tgodzik commented May 17, 2021

I just have 2.13.6 support ready in semanticdb soon, so I will include it here also.

@tgodzik
Copy link
Contributor Author

tgodzik commented May 17, 2021

Ok, it's getting late, so I will postpone the release until tomorrow. Sorry everyone about that!

@tgodzik tgodzik merged commit 460580c into scalameta:main May 18, 2021
@tgodzik tgodzik deleted the release-0.10.3 branch May 18, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants