Add support for Scala 3.0.1-RC1 #2852
Conversation
tgodzik
force-pushed
the
add-support
branch
3 times, most recently
from
e922088
to
0560fa4
Compare
tgodzik
force-pushed
the
add-support
branch
2 times, most recently
from
8e03515
to
50ece65
Compare
| @@ -151,7 +172,9 @@ class CompletionProvider( | |||
|
|
|||
| def hasGetter = try { | |||
| // isField returns true for some classes | |||
| sym.isField || sym.getter != NoSymbol | |||
| (sym.isField && !sym.is(JavaDefined) | |||
There was a problem hiding this comment.
sym.isField was returning true for a bunch of java classes
| @@ -259,7 +282,7 @@ class CompletionProvider( | |||
| ) | |||
| if (byParamCount != 0) byParamCount | |||
| else { | |||
| s1.show.compareTo(s2.show) | |||
| s1.detailString.compareTo(s2.detailString) | |||
There was a problem hiding this comment.
We should compare the full signature, show for symbol was mostly just name, which wasn't an issue prior to 3.0.1, since before the completions with the same symbol name were grouped together.
| } | ||
| val typeString = symbols.headOption.map { symbol => | ||
| symbols.flatMap(ParsedComment.docOf(_)) | ||
| val hoverString = symbols.headOption.map { symbol => |
There was a problem hiding this comment.
Improved it to return the full hover string here, full separation was actually problematic to maintain.
| @@ -147,7 +147,7 @@ class HoverDefnSuite extends BaseHoverSuite { | |||
| |""".stripMargin, | |||
| "", | |||
| compat = Map( | |||
| "3.0" -> "object MyObject: MyObject".hover | |||
| "3.0" -> "object MyObject: object".hover | |||
There was a problem hiding this comment.
object is the name of the package, same in all the other tests.
| @@ -147,7 +147,7 @@ class HoverTermSuite extends BaseHoverSuite { | |||
| |""".stripMargin.hover, | |||
| compat = Map( | |||
| // https://github.com/lampepfl/dotty/issues/8835 | |||
| "3.0" -> "object num: Xtension#num".hover | |||
| "3.0" -> "object num: interpolator-unapply.a$.Xtension".hover | |||
There was a problem hiding this comment.
This is wrong anyway, we can fix it in a separate PR.
|
Integration tests seem to be failing unrelated to the changes. I need to take a look at it separately, I think it's one of the test that randomly start failing :( |
This also includes a bunch of fixes that were kind of a chain reaction due to some tests failing for 3.0.1-RC1 - print outer type instead of singleton type for objects - make sure to take method signature into account when filtering or sorting symbols
|
The weird test failure disappeared 🤔 not sure what it was caused by. |
This also includes a bunch of fixes that were kind of a chain reaction due to some tests failing for 3.0.1-RC1