New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Docusaurus 2.0 #2927
Update to Docusaurus 2.0 #2927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Looks pretty neat. I have some doubts about:
O we able to modify it to some other picture or just text? It's kind of weird to have these emoticons there.
So by default that's what they use. I think it's pretty standard as well since when you look around for examples of light/dark mode switches you often see them with a sun and moon icon to notify the user which they are on. Is there something specific about them that you don't like or that worries you?
EDIT:
It looks like you can switch the icons, but I'm unsure what we'd switch them to. https://docusaurus.io/docs/api/themes/configuration#color-mode---dark-mode
That's I guess personal preference, it kind of looks like an old communicator icon, so I might be biased because of that. It's just weird to see emoticons, where they are not needed. Even plain sun/moon would be much better. This is the polish communicator I am always thinking about with this. |
Let me see if I can find two plain icons. |
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side! Tested it locall and everything seems to work.
Cool, I'll wait for another day to see if the others have any input, if now I'll merge away! |
Publish failed. Looks like a command isn't found, digging into it now. |
So there are a bunch of changes here and I still need to update a last few things.
/metals/
root in order for it to deploy right on Vercel, so if you randomly click on something that is hardcoded tometals/docs
for example it will 404 just because on my published version it's justdocs/
. I've been able to locally though confirm that all the links are valid. It warns you now when you build if there are any.)Just to give a brief overview, taken from the Docusaurus website:
I also did this migration partially with their migration-helper, but there ended up being a pretty large chunk that needed to be done manually.
I published a temp version of the site at https://metals-test-ckipp01.vercel.app/ so feel free to poke around and let me know what you think.