Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: small build cleanups #3418

Merged
merged 2 commits into from Dec 30, 2021
Merged

refactor: small build cleanups #3418

merged 2 commits into from Dec 30, 2021

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Dec 30, 2021

This pr just changes a few small things in the build:

  • Moves the list of developers to project/Developers.scala
  • Takes deps that we use in multiple places and give them a V.name variable to use
  • Alphabetizes the versions in V
  • Removes duplicated deps declared in both mtags and metals

tgodzik
tgodzik approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It should be fine to merge, the scalafix issue is solved in main.

@ckipp01 ckipp01 merged commit 88f3b27 into scalameta:main Dec 30, 2021
@ckipp01 ckipp01 deleted the buildCleanup branch December 30, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckipp01 @tgodzik