Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic db info display on jar files #3843

Merged
merged 1 commit into from Apr 22, 2022

Conversation

Arthurm1
Copy link
Contributor

Displays semantic db info on java and scala jar files using the internal interactive db info. Jar files don't have a semanticdb file.

I've found this helpful when debugging goto/ref information on jar files.

Copy link
Member

@dos65 dos65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arthurm1 Looks good!
The only thing I'm not sure is new extensions semanticdb-internal-*.
Why we can use existing semanticdb-compact and others for jars?

@Arthurm1
Copy link
Contributor Author

@dos65 Good point. In fact I could just always check the interactive ones first and then fallback onto the file ones if interactive doesn't exist. The only time both file and interactive seem to exist is when there is an unsaved source file and we can't currently show the interactive ones for that because it involves passing the content as well as the uri.
I'll change it to do that.

@Arthurm1
Copy link
Contributor Author

Should be good now

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arthurm1 Arthurm1 merged commit caf638c into scalameta:main Apr 22, 2022
@Arthurm1 Arthurm1 deleted the interactive_semanticdb branch April 22, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants