Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add support for Scala 2.12.16 #4010

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 8, 2022

No description provided.

val scala213 = "2.13.8"
val scala3 = "3.1.2"
val nextScala3RC = "3.1.3-RC4"
val sbtScala = "2.12.14"
val ammonite212Version = scala212
val ammonite212Version = "2.12.15"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ammonite 2.12 stays on 2.12.15?

Copy link
Contributor Author

@tgodzik tgodzik Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ammonite is not yet available for 2.12.16

check(
"kind-projector",
"kind-projector".tag(IgnoreScalaVersion("2.12.16")),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried fixing it, but this would require a lot of work and I would rather focus on Scala 3 when fixing error in the compiler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe turn it into an issue?

Copy link
Contributor

@armanbilge armanbilge Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean in practice? Will metals users have issues with kind-projector on Scala 2.12.16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe turn it into an issue?

I mean, I could, but in reality I don't think it will be a high priority for anyone, so we would need to fix it ourselves :/ I will raise i , maybe someone has some ideas.

What does this mean in practice? Will metals users have issues with kind-projector on Scala 2.12.16?

I actually updated to the newest version and it seems the users already have issues 馃槗 At least for this particular case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check(
"kind-projector",
"kind-projector".tag(IgnoreScalaVersion("2.12.16")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe turn it into an issue?

@tgodzik tgodzik merged commit fa8e342 into scalameta:main Jun 9, 2022
@tgodzik tgodzik deleted the support-2.12.16 branch June 9, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants