Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java version through shell #4067

Merged
merged 12 commits into from Jul 8, 2022
Merged

Conversation

zmerr
Copy link
Contributor

@zmerr zmerr commented Jun 26, 2022

resolves #3536

@zmerr zmerr marked this pull request as draft June 26, 2022 13:38
@zmerr zmerr requested a review from tgodzik June 28, 2022 09:15
@zmerr zmerr requested a review from tgodzik June 28, 2022 10:16
@zmerr zmerr marked this pull request as ready for review June 28, 2022 13:46
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments from me, otherwise looks good!

zmerr and others added 2 commits July 8, 2022 16:22
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
@zmerr zmerr requested review from tgodzik and dos65 July 8, 2022 12:48
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and we should be able to merge it.

…veSemanticdb.scala

Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
@zmerr zmerr requested a review from tgodzik July 8, 2022 16:54
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit b1f8458 into scalameta:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaInteractiveSemanticDb - jdk version inferring issue
3 participants