New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java version through shell #4067
Conversation
metals/src/main/scala/scala/meta/internal/builds/ShellRunner.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/builds/ShellRunner.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/builds/ShellRunner.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/JavaInteractiveSemanticdb.scala
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/MetalsLanguageServer.scala
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/JavaInteractiveSemanticdb.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/JavaInteractiveSemanticdb.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/builds/ShellRunner.scala
Outdated
Show resolved
Hide resolved
metals/src/main/scala/scala/meta/internal/metals/JavaInteractiveSemanticdb.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments from me, otherwise looks good!
metals/src/main/scala/scala/meta/internal/metals/JavaInteractiveSemanticdb.scala
Outdated
Show resolved
Hide resolved
tests/unit/src/test/scala/tests/troubleshoot/ProblemResolverSuite.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last change and we should be able to merge it.
metals/src/main/scala/scala/meta/internal/metals/JavaInteractiveSemanticdb.scala
Outdated
Show resolved
Hide resolved
…veSemanticdb.scala Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
resolves #3536