bugfix: Print local type aliases properly #4188
Conversation
| // local type aliases | ||
| case ValueSignature(tp: s.TypeRef) if tp.symbol.isLocal => | ||
| textDocument.symbols.collectFirst { |
There was a problem hiding this comment.
what if type alias is defined in other file? It isn't local then.
There was a problem hiding this comment.
Then it should work normally, the problem is with printing local type aliases as far as I was able to check. Or do you have a counter example?
There was a problem hiding this comment.
Changed the test to include a nonlocal type.
There was a problem hiding this comment.
Right, non local type was working, my bad.
| // local type aliases | ||
| case ValueSignature(tp: s.TypeRef) if tp.symbol.isLocal => | ||
| textDocument.symbols.collectFirst { |
There was a problem hiding this comment.
Right, non local type was working, my bad.
There was a problem hiding this comment.
@tgodzik Looks good but I'm wondering why we have this line in printer ?
I removed it locally and without it the new test works well without changes in SyntheticDecorationProvider
Previously, we would not print local type names properly and instead just print "_". Now we search for the display name of that local type alias and display it instead. Fixes scalameta#4186
Good catch! I changed that a bit to have |
Previously, we would not print local type names properly and instead just print "_". Now we search for the display name of that local type alias and display it instead.
Fixes #4186