Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement basic Text Explorer support for scalatest #4281

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

kpodsiad
Copy link
Member

@kpodsiad kpodsiad commented Aug 20, 2022

needs scalameta/metals-vscode#1117

Supports:

  • AnyFunSuite
  • AnyPropSpec
  • AnyFlatSpec
  • AnyFunSpec
  • AnyWordSpec
  • AnyFreeSpec

Example:
Screenshot 2022-08-20 at 08 09 39

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I have one comment, but feel free to merge if you don't have time to address it.

)

check(
"any-prop-spec",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests that actually run the test cases that were found? If not that would be great to add at least some.

Copy link
Member Author

@kpodsiad kpodsiad Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such tests would be a great addition, but unfortunately there aren't any currently. Good idea for future

@kpodsiad kpodsiad merged commit 1832a3c into scalameta:main Aug 23, 2022
@kpodsiad kpodsiad deleted the feat/scalatest branch August 23, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants