Add cross tests for pattern only case completions, fix for typed case completions #4356
Conversation
| ), | ||
| true, | ||
| false, |
There was a problem hiding this comment.
Could you use named arguments for all the booleans?
| | } | ||
| |}""".stripMargin, | ||
| """|None scala | ||
| |Some[_] scala |
There was a problem hiding this comment.
| |Some[_] scala | |
| |Some[?] scala |
_ might get deprecated at some point
| | case _: N@@ => | ||
| | } | ||
| |}""".stripMargin, | ||
| """|None scala |
There was a problem hiding this comment.
None is an object, so ideally we shouldn't suggest it
jkciesluk
changed the title
jkciesluk
force-pushed
the
patternsuite
branch
from
454ae9f
to
5800185
Compare
| case (sel @ Select(qualifier, name)) :: _ | ||
| if "match".startsWith(name.toString()) && text.charAt( | ||
| completionPos.start - 1 | ||
| ) == ' ' => |
There was a problem hiding this comment.
it also might be a .
I found this usage recently at https://dotty.epfl.ch/docs/reference/other-new-features/indentation.html
one
+ two.match
case 1 => b
case 2 => c
+ three
There was a problem hiding this comment.
In the first, main PR about match case completions for scala3 we came to conclusion to show match completions after two.match but not two.m, two.ma etc. because I think most users aren't using this syntax and having match completion there might be confusing (also, match completions are exclusive, maybe we should change that?)
There was a problem hiding this comment.
I think we can make match completions not exclusive, to enable things like xxx.match@@ and completion xxx.matches(), but it's better to not show match completions in xxx.mat@@ (only for xxx.match@@)
| case Some(query) => CompletionFuzzy.matches(query, name) | ||
|
|
||
| def toCompletionValue( | ||
| sym: Symbol, | ||
| name: String, | ||
| autoImports: List[l.TextEdit], | ||
| )(using Context): CompletionValue.CaseKeyword = | ||
| )(using Context): Option[CompletionValue.CaseKeyword] = | ||
| sym.info |
| """|head :: next scala.collection.immutable | ||
| |Nil scala.collection.immutable""".stripMargin |
There was a problem hiding this comment.
Shouldn't these result be filtered out by fuzzy-match?
There was a problem hiding this comment.
There is a problem, because new is not seen on path (the tree looks the same as for case@@. I'm looking into it, if I won't find a solution soon I will create an issue
There was a problem hiding this comment.
fuzzy-match isn't working, because compiler doesn't see the Ident("new")
There was a problem hiding this comment.
I've created an issue #4367
Adds a cross tests suite to check if we cover all cases like
case _: @@,case xxx @ So@@etc.Also fixes sorting completions when
CaseKeywordCompletionsare not exclusive.Edit: I moved all extractors to one place