Ivy Completions Dash Fix #4405
Merged
Ivy Completions Dash Fix #4405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the incorrect start of text edits when '-' appears in a dependency used for ivy completions. For example `io.get-coursier`. Also remove the setting of the Scala binary version when creating the coursier api as this is now handled by coursier-interface in 1.0.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is a small PR which fixes TextEdit ranges when
-appears in a dependency used for ivy completions. Previously for example, selectingio.get-coursieratio.get-coursi|would leave you withio.get-io.get-coursier.I tried to find out if there were any other chars that potentially could appear in artefact ids, https://maven.apache.org/guides/mini/guide-naming-conventions.html is not overly specific:
then you can choose whatever name you want with lowercase letters and no strange symbols馃槅Also snuck in: remove setting the Scala binary version when creating the coursier api which is no longer needed since #4390 (mentioned in previous PR).